Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set UID, GID of downloaded files. #35

Open
ajurna opened this issue May 27, 2023 · 8 comments
Open

Set UID, GID of downloaded files. #35

ajurna opened this issue May 27, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@ajurna
Copy link
Contributor

ajurna commented May 27, 2023

Is your feature request related to a problem? Please describe.
the container runs as root but i don't want to store my comics with root user and group.

Describe the solution you'd like
support for setting the uid and gid of the files downloaded.

Additional context
would also be nice to set the umask for the files as well. 644 might not be what people want.

@ajurna ajurna added the enhancement New feature or request label May 27, 2023
@Casvt
Copy link
Owner

Casvt commented May 27, 2023

Duplicate of #33 ?

@ajurna
Copy link
Contributor Author

ajurna commented May 27, 2023

nope, that's for its running context. while it could accomplish the same it's not exactly the same thing. this would allow you to continue running as root in the container but the file permissions would change.

@Berserkir-Wolf
Copy link
Collaborator

Sounds like wanting to support UMASK (like linuxserver images), which maps the container root to a local user with less-than-root access.
That about right, @ajurna ?

@Berserkir-Wolf
Copy link
Collaborator

The above change creates a container-local user (so only existing in the container) named kapowarr on startup of the container, with a PUID:PGID able to be defined in environment variables.
The user has sudo/root access in the container, but does not on the host system.

@ajurna
Copy link
Contributor Author

ajurna commented Jun 12, 2023

That is correct

@Berserkir-Wolf
Copy link
Collaborator

Awesome. In that case, once the PR is reviewed (and hopefully accepted), the next build will support it.

@ajurna
Copy link
Contributor Author

ajurna commented Jun 15, 2023

although looking at the docs changes that are being brought in for #59 having a umask setting could still be useful.

@ignacio82
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Handled Soon
Development

No branches or pull requests

4 participants