Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material You support #995

Closed
lokesh-krishna opened this issue Jun 23, 2023 · 7 comments
Closed

Material You support #995

lokesh-krishna opened this issue Jun 23, 2023 · 7 comments

Comments

@lokesh-krishna
Copy link

Description of the issue

Will upstream Material You support be added? This was a part of the 1.23.5 release.

@Catfriend1
Copy link
Owner

Why should that be added? Just use the other version :).

@Rorschach1010
Copy link

hmm... it doesn't sound like you have a reason not to implement that. Obviously it's your choice but telling users to just use a different app which has feature XY is kinda a strange argumentation.

In any way, I would like Material You too, with your fork but as I said, it's totally up to you.

@Catfriend1
Copy link
Owner

I don't want to argument... Do you like to take a go on implementing?

@KraXen72
Copy link

i think Material You from upstream would greatly improve the visuals of the app. plus, most of the work is already done by upstream, you should only need to implement the changed ui parts from upstream.

@Catfriend1
Copy link
Owner

Do you like to take a go on implementing, especially make a PR?

@KraXen72
Copy link

KraXen72 commented Feb 20, 2024

no, i do not know kotlin that well. My opinion is that this would be a nice to have feature, but if you won't add it unless someone else makes a PR, that's fine. I can survive with the old ui, i barely open the app anyway, it just syncs.

@otoayana
Copy link

otoayana commented Mar 9, 2024

i'm upping this tbh. i know it's not a big deal now, but the current material design version within the app is from 2016ish, and nowadays it looks a bit dated. i know function is prioritised over form in this case, but it would look more in place with today's phones. i might see if i can port this from the PR in upstream syncthing, authoring Bnyro ofc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants