Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Multiple barcode support #53

Closed
TheLastProject opened this issue Oct 24, 2020 · 4 comments
Closed

WIP: Multiple barcode support #53

TheLastProject opened this issue Oct 24, 2020 · 4 comments

Comments

@TheLastProject
Copy link
Member

Issue by TheLastProject
Saturday Jan 04, 2020 at 23:45 GMT
Originally opened as brarcher/loyalty-card-locker#337


After seeing #279, I felt the tabs were a good way to support multiple barcodes.

Fixes #264 and I feel it also fixes #279 (because multiple barcodes per store make this possible, just note what the code is for). I am also going to assume this fixes #286 as the user's primary concern seems to be an easier way to add another card from a store they already have.

This code groups together every loyalty card with the same store name and, if multiple loyalty cards with the same store name exist, adds a scrollable tabview to switch between them. The text on each tab is based on the note. If there is no note for that specific loyalty card, it falls back to numbering them. It also switches to using a floating action button. Clicking the "+" button when viewing a loyalty card will start the edit activity with the store name pre-filled, to make adding additional cards to the same store easy.

Some screenshots:
photo_2020-01-05_00-41-56
photo_2020-01-05_00-41-57
photo_2020-01-05_00-42-00
photo_2020-01-05_00-42-01


TheLastProject included the following code: https://github.com/brarcher/loyalty-card-locker/pull/337/commits

@TheLastProject
Copy link
Member Author

Comment by TheLastProject
Sunday Jan 05, 2020 at 15:47 GMT


photo_2020-01-05_16-46-46
This is a bit of an issue though... Not sure how to fix it... kinda always was an issue but this new feature definitely makes it worse...

@TheLastProject
Copy link
Member Author

Comment by TheLastProject
Monday Jan 06, 2020 at 20:58 GMT


I moved the tab bar into the header, which at least makes the situation not worse than it used to be.
photo_2020-01-06_21-57-01

@TheLastProject
Copy link
Member Author

Comment by TheLastProject
Saturday Feb 22, 2020 at 14:38 GMT


This sadly seems to conflict with the feature introduced in #348 and I'm not quite sure how to fix that :(

@TheLastProject
Copy link
Member Author

I'm abandoning this branch because it conflicts with brarcher/loyalty-card-locker#348 and because it probably won't work well with groups either. We need new logic for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant