Localization fixes

[moo-man]

Untranslatable Strings

• Characteristic Abbreviations

• Missing LoreDescription.Shadows in en.json

Bugs

• /char - career button

• Items - Size (All specifications as well), Hardy, Small, Mindless, Construct, Armour, Swarm

[LeRatierBretonnien]

Allow translation of 'yards' in Range (for example)

[LeRatierBretonnien]

Description of 'Draught Horse' is wrong in trappings.db : this is not a war horse :)
Same for 'Monkey'
Same for 'Riding Horse'
Same for 'Poney'

Description of 'Saddlebags' is wrong

[LeRatierBretonnien]

Enable translation of money : Brass Penny/Gold Crown/Silver Shilling

[Moilunator]

Hi Moo Man, I'm French and I help translate the compendium psychologies and I don't find "Love" in it. Is it an oversight or a choice ?

[moo-man]

@Moilunator Love was an example custom psychology, I'm not sure if that's detailed in the French translation, I would imagine it is, I can send you the text if not.

[Moilunator]

I've Love in the french rulesbook, but Love is not included in the compendium (Camaraderie, Phobia and Trauma are).

[moo-man]

@Moilunator Sorry my apologies, I misinterpreted. Yeah, looks like an oversight, I'll add it next update

[LeRatierBretonnien]

CSS (table/celll?) overflow with "Augmentations", cf snapshot

[LeRatierBretonnien]

When clicking on a prayer spell (blessing or another), the "Roll" window is displayed, but the skill linked with it is "Fellowship", instead of "Pray" -> this can lead to wrong rolls results.

[moo-man]

@sladecraven
Is this a localization issue? If you've changed the skill names it would be expected

[LeRatierBretonnien]

@moo-man
OK, yes, skill names are translated. So how to manage this properly ? On your side or on my side ?

[moo-man]

@sladecraven that'd be my side, I've gotta add support to recognize localized item names

[LeRatierBretonnien]

Ok, clear !

[LeRatierBretonnien]

Weapon qualities must be handled thru 'translation'. For example :
dice-wfrp4e.js: if (weapon.properties.qualities.includes("Impale")
should be (i guess) :
dice-wfrp4e.js: if (weapon.properties.qualities.includes("WFRP4E.Properties.Impale")

[Antares117]

Bonjour je viens de voir que les dégats de la grande Ache ne sont pas bon : + au lieu de +6.
Et encore merci pour le travail que vous effectué

[LeRatierBretonnien]

When using names with a ' inside, the findItem function is failing, and the associated text is not displayed in the chat.
Example : In french, the translation of "Ear Bash" is "Frappe à l'oreille" -> this outputs an error in line 801 of dice-wfrp4e.js (dev-backend branch) when clicking in the critical name in the chat.
Without the ' (ie "Frappe à l oreille"), it does not raise the eror
->FIXED on FR SIDE - Wrong char. used by translator

[LeRatierBretonnien]

When searching a skill for a weapon, the search key is not enough robust.
In actor/actor-wfrp4e.js, the line :
weapon.skillToUse = skills.find(x => x.name.toLowerCase().includes(weapon.data.weaponGroup.value.toLowerCase()))
Should be :
weapon.skillToUse = skills.find(x =>x.name.toLowerCase().includes("("+weapon.data.weaponGroup.value.toLowerCase()+")"))
`

This avoid selection of wrong skill when a part of the name is matching. This is the case for example for the word Arc (ie Bow in french) that match the skill Marchandage (ie Haggle in French).

[LeRatierBretonnien]

Allow translate of distance unit : yd/yds/yards should be keyed in lang/endjson (replaced by meters in other translations).

[LeRatierBretonnien]

/cond command should search in WFRP4E.conditions string, not keys, in order to allow searching in translated names.

[LeRatierBretonnien]

in actor-sheet.js, in line 361 :
let improvId = weapons.find(w => w.name.toLowerCase() == "improvised weapon");
"improvised weapon" -> should be localized with NAME.Improvised

[LeRatierBretonnien]

In actor-sheet.js, line 382,
let skill = this.actor.items.find(s => s.data.name == game.i18n.localize("NAME.Enurance") && s.type == "skill")
"NAME.Enurance" -> should be NAME.Endurance

[JiDW]

the utility function "allMoneyItems" is using English labels to look into the compendium for adding GC/SS/BP to new actors.

utility-wfrp4e.js, line 679