Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-512 allo package imports only #19

Merged
merged 1 commit into from
Feb 4, 2023
Merged

PAINTROID-512 allo package imports only #19

merged 1 commit into from
Feb 4, 2023

Conversation

davidmoling
Copy link
Contributor

@juliajulie95
Copy link
Contributor

Code looks fine, github action currently fails because of protoc setup, which is not related to this PR though

@juliajulie95
Copy link
Contributor

After a re-run action completed succesfully

@CodeChamp-SS
Copy link
Member

The changes LGTM, please resolve the merge conflicts

CodeChamp-SS
CodeChamp-SS approved these changes Feb 4, 2023
View reviewed changes
Copy link
Member

@CodeChamp-SS CodeChamp-SS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeChamp-SS CodeChamp-SS merged commit 77ef7fe into Catrobat:develop Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliajulie95 juliajulie95 juliajulie95 approved these changes

@CodeChamp-SS CodeChamp-SS CodeChamp-SS approved these changes

@krispykalsi krispykalsi Awaiting requested review from krispykalsi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@davidmoling @juliajulie95 @CodeChamp-SS