Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ase.filters ModuleNotFoundError in example notebook #127

Closed
2 of 4 tasks
kaijiz opened this issue Feb 21, 2024 · 9 comments
Closed
2 of 4 tasks

ase.filters ModuleNotFoundError in example notebook #127

kaijiz opened this issue Feb 21, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@kaijiz
Copy link

kaijiz commented Feb 21, 2024

Email (Optional)

kaijiz@tamu.edu

Version

v0.3.0

Which OS(es) are you using?

  • MacOS
  • Windows
  • Linux

What happened?

Screen Shot 2024-02-21 at 4 12 44 PM Hi, when I tried to use the notebook example, I got this error and I don't know how to fix it, could you help me?

Code snippet

No response

Log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kaijiz kaijiz added the bug Something isn't working label Feb 21, 2024
@BowenD-UCB
Copy link
Collaborator

Thanks for the report.
We just added the install of ase gitlab to the example notebook.
The example notebook should work now, please check again.

@kaijiz
Copy link
Author

kaijiz commented Feb 21, 2024

hi, I still meet that problem, maybe it's because the version of ase is not right?

@BowenD-UCB
Copy link
Collaborator

If you're running this on Google colab, the ase gitlab version will be automatically installed by running the first block.
If you're running locally and don't have the latest ase version, please run
pip install git+https://gitlab.com/ase/ase

@BowenD-UCB BowenD-UCB changed the title [Bug]: ase.filters in example notebook Feb 21, 2024
@kaijiz
Copy link
Author

kaijiz commented Feb 21, 2024

Thanks for your reply. I know this and I have done this. But still met this error. I think ase 3.22 no longer has "filters" module. I am trying to find which version has this module.

@BowenD-UCB
Copy link
Collaborator

ASE pypi hasn't been released for 2 years.
So you have to install from their gitlab source with
pip install git+https://gitlab.com/ase/ase

@kaijiz
Copy link
Author

kaijiz commented Feb 21, 2024

So could you run this Notebook "structure optimization" example without errors? I want to figure out it's my mistake or something wrong with the example.

https://colab.research.google.com/github/CederGroupHub/chgnet/blob/main/examples/basics.ipynb

@kaijiz
Copy link
Author

kaijiz commented Feb 21, 2024

oh i found how to fix it. you put "pip install git+https://gitlab.com/ase/ase" in the wrong place. should put in the "try" part instead of 'except' part.

@BowenD-UCB
Copy link
Collaborator

@kaijiz This is probably because you didn't restart the kernel in Google Colab.
Google Colab kermel should run the except part, because it needs to install chgnet

@thienbinh92
Copy link

I got the same issue. I install ase3.22.1. ase.filters module is not in the package anymore.

@janosh janosh changed the title ase.filters in example notebook ase.filters ModuleNotFoundError in example notebook Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants