Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final touches #4

Merged
merged 3 commits into from Jun 24, 2022
Merged

Final touches #4

merged 3 commits into from Jun 24, 2022

Conversation

Ceemos96
Copy link
Owner

In this milestone I :

  • Ensured that there are no linter errors.
  • improved the look and feel of the application, adding the styles of your choice.
  • kept the general layout of the wireframe, this is the only mandatory requirement.

Copy link

@roshan-bajgain roshan-bajgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ceemos96,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors. ✔️
  • GitHub flow is followed. ✔️
  • Professional README file. ✔️
  • PR has a good title and summary. ✔️

Optional suggestions

  • I would suggest you write the step on the README file to open the project in the browser eg: npm install and to run it use: npm start
  • To make the looks of the project better kindly use the background image and some font on the text. Let's make better looks of the project

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Ceemos96 Ceemos96 merged commit 5a3be87 into development Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants