RevertableDict (Workaround - Fix?) #156

MARLBORO-NEW · 2022-10-20T14:34:03Z

Tried a few things and was able to make it work with 4 changes:
unrpyc.py line 85 replace "renpy.python" with "renpy.revertable"
magic.py line 112 replace "if args or kwargs:" with "if (args or kwargs) and args != ([],) and kwargs != {}:"
util.py line 222 replace "if arginfo.extrapos:" with "if hasattr(arginfo,'extrapos') and arginfo.extrapos:"
util.py line 225 replace "if arginfo.extrakw:" with "if hasattr(arginfo,'extrakw') and arginfo.extrakw:"

I'm no qualified dev so use at your own risk. So far worked for every RPYC I tested (with python 2.7 on macos)

Mzyxptlk · 2022-10-26T11:58:39Z

I've used the same fix in unrpyc.py on lines 80 and 90, for RevertableList and RevertableSet, respectively. Unfortunately, while this fixes some games that fail to decompile with v1.1.8, it breaks some other games that work fine with v1.1.8, so YMMV.

LordVenom · 2022-11-04T09:08:43Z

Hello, someone would have un.rpy compile with the modification?

renkerenke · 2022-11-06T11:40:42Z

Thank you for the workaround! No idea what you used for testing but it works flawlessly with the current version of Tales from the Unending Void.

CensoredUsername · 2022-12-04T17:48:05Z

@MARLBORO-NEW could you please state what this is supposed to fix 😅

MARLBORO-NEW · 2022-12-04T19:53:58Z

Lol, as stated in the title this should fix the RevertableDict error that shows up on most recent games. Same error reported on various other posts.

CensoredUsername · 2022-12-04T20:47:05Z

If you don't write down what game / ren'py version something occurs with I have a hard time trying to reproduce the error or fix ;) There's a reason there's a section on issue reporting in the README to keep this section somewhat organized. Honestly, I really want to just delete issues that do not even take the time to provide enough information. If you name your whole issue just the name of a type and then refuse to provide any information in the issue it costs me a lot more time to figure it out. I spent a lot of time on this tool and provided people it free of charge, so please understand that I'm not very amused if people cannot even take the time to actually write a full sentence on what the actual problem is, or keep making new issue threads for the same bug.

For reference, the correct approach would be to make an issue, put Ren'py version: TypeError: 'RevertableDict' object does not support item assignment in the title, provide the requested info in the issue comment and if you have one, provide the workaround you found in a comment. That way I can actually work on it if I find some time instead of having to trawl thought the absolute mess this issue tracker is right now.

MARLBORO-NEW · 2022-12-04T22:09:03Z

Hi, ok. Just delete my message.Was trying to help as quiet a lot of posts already have the same report. Found a workaround and was just trying to help those still not able to use the tool.But if providing a workaround, referencing all the posts about the same topic so you don’t need to look for all of them is still not enough….go ahead.I do have a working solution.RegardsSent from my iPhoneOn 4 Dec 2022, at 21:47, CensoredUsername ***@***.***> wrote: If you don't write down what game / ren'py version something occurs with I have a hard time trying to reproduce the error or fix ;) There's a reason there's a section on issue reporting in the README to keep this section somewhat organized. Honestly, I really want to just delete issues that do not even take the time to provide enough information. If you name your whole issue just the name of a type and then refuse to provide any information in the issue it costs me a lot more time to figure it out. I spent a lot of time on this tool and provided people it free of charge, so please understand that I'm not very amused if people cannot even take the time to actually write a full sentence on what the actual problem is, or keep making new issue threads for the same bug. For reference, the correct approach would be to make an issue, put Ren'py version: TypeError: 'RevertableDict' object does not support item assignment in the title, provide the requested info in the issue comment and if you have one, provide the workaround you found in a comment. That way I can actually work on it if I find some time instead of having to trawl thought the absolute mess this issue tracker is right now. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

MARLBORO-NEW · 2022-12-05T17:22:11Z

@CensoredUsername : Sorry previous reply was done while in rush and by reading it I realise it sounds rude.
English not my native language and being in a rush I expressed myself very poorly (yet does not not excuse it).
So really sorry.
What I meant to say it's that I tried to link all the other treads referring to the same issue. Thought by avoiding to repeat everything that was already said in this thread you would have less to read and merge.
Obviously it's not a good practice, sorry for that. It's my first post on Github and I'm not a IT professional so, excuse me for the noob way.
Will avoid repeating same errors.

CensoredUsername · 2022-12-07T18:03:58Z

Hey, no offense taken. I just get a lot of really bad issue requests so I've found I need to be really strict on it lest people just file stuff like "Doesn't work with game x" - "see title" or "doesn't work with python 3.10" where people clearly didn't even bother to read the readme. I do appreciate the contribution, it's just a bit nicer to keep it in the already existing issue thread and mark / close any other duplicates to link towards that one. Less threads to police that way.

madeddy · 2022-12-08T15:28:06Z

@MARLBORO-NEW

unrpyc.py line 85 replace "renpy.python" with "renpy.revertable"

magic.py line 112 replace "if args or kwargs:" with "if (args or kwargs) and args != ([],) and kwargs != {}:"

util.py
a. line 222 replace "if arginfo.extrapos:" with "if hasattr(arginfo,'extrapos') and arginfo.extrapos:"
b. line 225 replace "if arginfo.extrakw:" with "if hasattr(arginfo,'extrakw') and arginfo.extrakw:"

I used your code with some changes(especially item 1.; with help from user@VepsrP), added set to class factory and packed it together to a PR. The pull from sigio isn't enough to cover all new Ren'py incompatibility. So thanks for your share in this.

I you're interested check #161

DoctorBooooom · 2023-01-23T09:45:18Z

Got decompile error too (with latest version on unrpyc):

PS C:\Users\DB\Desktop\unrpyc-master> py -2 .\unrpyc.py .\location.rpyc
Decompiling .\location.rpyc to .\location.rpy...
Error while decompiling .\location.rpyc:
Traceback (most recent call last):
  File "C:\Users\DB\Desktop\unrpyc-master\unrpyc.py", line 202, in worker
    tag_outside_block=args.tag_outside_block, init_offset=args.init_offset, try_harder=args.try_harder)
  File "C:\Users\DB\Desktop\unrpyc-master\unrpyc.py", line 165, in decompile_rpyc
    ast = read_ast_from_file(in_file)
  File "C:\Users\DB\Desktop\unrpyc-master\unrpyc.py", line 138, in read_ast_from_file
    data, stmts = magic.safe_loads(raw_contents, class_factory, {"_ast", "collections"})
  File "C:\Users\DB\Desktop\unrpyc-master\decompiler\magic.py", line 599, in safe_loads
    encoding=encoding, errors=errors).load()
  File "C:\Python27\lib\pickle.py", line 864, in load
    dispatch[key](self)
  File "C:\Python27\lib\pickle.py", line 1212, in load_setitems
    dict[stack[i]] = stack[i + 1]
TypeError: 'RevertableDict' object does not support item assignment

Decompilation of 1 file failed

File: https://mega.nz/file/rCwlQbpZ#0_ssCNLbUtGZ3kN-h2tx1RsD7vApSO2ej1w2S8hW2DM

Windows-10-10.0.19041
Ren'Py 7.5.3.22090809

madeddy · 2023-01-27T10:59:56Z

The actual official unrpyc is only compatible with RenPy below version 7.5 and the fixes posted here are regrettably incomplete.

If you`re somewhat proficient with python, you can try and play around with the fixed unrpyc versions in my fork. Especially the one based on last unrpyc 1.1.8 or the very adventurous 1.2.0 version.

B01scout · 2023-02-12T10:26:21Z

The actual official unrpyc is only compatible with RenPy below version 7.5 and the fixes posted here are regrettably incomplete.

If you`re somewhat proficient with python, you can try and play around with the fixed unrpyc versions in my fork. Especially the one based on last unrpyc 1.1.8 or the very adventurous 1.2.0 version.

Thanks for the pull request! Decompiling of 94 files worked.

awcator · 2023-10-24T11:50:18Z

Thank you this works even in 2023 Oct

CensoredUsername · 2024-02-12T03:44:13Z

These issues should be properly fixed on dev now for ren'py 7.5

MARLBORO-NEW changed the title ~~RevertableDict (Workaround - Fix?~~ RevertableDict (Workaround - Fix?) Oct 20, 2022

This was referenced Oct 20, 2022

RevertableDict (not fixed with set) #152

Closed

FakeUnpicklingError and TypeError #149

Closed

Suggested changes from #146 / Support renpy 7.5.0 #154

Closed

madeddy mentioned this issue Dec 4, 2022

Renpy 8 and 7.5 compat fix #161

Closed

FurryR mentioned this issue Mar 12, 2023

Error -3 while decompressing data: incorrect header check #130

Closed

awcator mentioned this issue Oct 24, 2023

windows 10: "revertabledict doesnt support item assignment #170

Closed

CensoredUsername added the Ren'py 7 and below label Feb 10, 2024

CensoredUsername closed this as completed Feb 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RevertableDict (Workaround - Fix?) #156

RevertableDict (Workaround - Fix?) #156

MARLBORO-NEW commented Oct 20, 2022 •

edited

Loading

Mzyxptlk commented Oct 26, 2022 •

edited

Loading

LordVenom commented Nov 4, 2022

renkerenke commented Nov 6, 2022

CensoredUsername commented Dec 4, 2022

MARLBORO-NEW commented Dec 4, 2022

CensoredUsername commented Dec 4, 2022

MARLBORO-NEW commented Dec 4, 2022 via email

MARLBORO-NEW commented Dec 5, 2022

CensoredUsername commented Dec 7, 2022

madeddy commented Dec 8, 2022

DoctorBooooom commented Jan 23, 2023 •

edited

Loading

madeddy commented Jan 27, 2023 •

edited

Loading

B01scout commented Feb 12, 2023

awcator commented Oct 24, 2023

CensoredUsername commented Feb 12, 2024

RevertableDict (Workaround - Fix?) #156

RevertableDict (Workaround - Fix?) #156

Comments

MARLBORO-NEW commented Oct 20, 2022 • edited Loading

Mzyxptlk commented Oct 26, 2022 • edited Loading

LordVenom commented Nov 4, 2022

renkerenke commented Nov 6, 2022

CensoredUsername commented Dec 4, 2022

MARLBORO-NEW commented Dec 4, 2022

CensoredUsername commented Dec 4, 2022

MARLBORO-NEW commented Dec 4, 2022 via email

MARLBORO-NEW commented Dec 5, 2022

CensoredUsername commented Dec 7, 2022

madeddy commented Dec 8, 2022

DoctorBooooom commented Jan 23, 2023 • edited Loading

madeddy commented Jan 27, 2023 • edited Loading

B01scout commented Feb 12, 2023

awcator commented Oct 24, 2023

CensoredUsername commented Feb 12, 2024

MARLBORO-NEW commented Oct 20, 2022 •

edited

Loading

Mzyxptlk commented Oct 26, 2022 •

edited

Loading

DoctorBooooom commented Jan 23, 2023 •

edited

Loading

madeddy commented Jan 27, 2023 •

edited

Loading