Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in env variables between upstream postgres image and centos one #36

Closed
rtnpro opened this issue Dec 14, 2015 · 5 comments
Closed

Comments

@rtnpro
Copy link
Contributor

rtnpro commented Dec 14, 2015

It seems that centos/postgresql-94-centos7 container uses different but similar environment variables in contrast to upsteam postgres container. This prohibits using centos/postgresql-94-centos7 in application images depending on official postgres container image, e.g.. sentry, without customizing them.

We could use the same nomenclature for the environment variables in the centos based and official postgres container images. This will make adopting centos/postgresql-94-centos7 image much more easier.

@rtnpro
Copy link
Contributor Author

rtnpro commented Dec 14, 2015

@kbsingh what do you think?

@jperrin
Copy link
Collaborator

jperrin commented Dec 15, 2015

Do you have a patchset we could adopt to be compliant with what is expected?

@rtnpro
Copy link
Contributor Author

rtnpro commented Dec 15, 2015

@jperrin I will work on a patch for the fix and send a PR :)

@goern
Copy link
Contributor

goern commented Apr 19, 2016

@rtnpro ping

@rtnpro
Copy link
Contributor Author

rtnpro commented Apr 19, 2016

@goern This got fixed in #37. Closing this issue.

@rtnpro rtnpro closed this as completed Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants