New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't repeat yourself #12

Closed

r-barnes opened this issue Jun 26, 2020 · 3 comments

Contributor

r-barnes commented Jun 26, 2020

These blocks have near-duplicate functionality. Good coding practice is to abstract repetition into functions, please do so.

openjournals/joss-reviews#2276

Contributor Author

r-barnes commented Jun 26, 2020 •

edited

Contributor Author

r-barnes commented Jun 26, 2020

KevinShook mentioned this issue

Create requirements.txt #40

Merged

Contributor

KevinShook commented Feb 8, 2021

The code has been cleaned up and we have removed the duplications

r-barnes closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment