Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract UI control #14

Closed
r-barnes opened this issue Jun 26, 2020 · 1 comment
Closed

Abstract UI control #14

r-barnes opened this issue Jun 26, 2020 · 1 comment

Comments

@r-barnes
Copy link
Contributor

These lines show a large amount of duplication. This could be reduced by looping over a list of components to enable/disable. It also suggests that perhaps the UI should be broken into separate controller classes that can be enabled/disabled separately. Handling everything in single mass code blocks is a recipe for low maintainability.

openjournals/joss-reviews#2276
@KevinShook KevinShook mentioned this issue Feb 4, 2021
Merged
@KevinShook
Copy link
Contributor

The duplication of lines has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@r-barnes @KevinShook