Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate current harness tests to sqlness #397

Closed
ShiKaiWi opened this issue Nov 15, 2022 · 11 comments · Fixed by #473
Closed

Migrate current harness tests to sqlness #397

ShiKaiWi opened this issue Nov 15, 2022 · 11 comments · Fixed by #473
Assignees
Labels
A-test Area: Unit or integration test cases, or test framework feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ShiKaiWi
Copy link
Member

Describe This Problem

sqlness has been created as a separated repo, but ceresdb doesn't use it now.

Proposal

Let's migrate the harness tests to the sqlness.

Additional Context

No response

@ShiKaiWi ShiKaiWi added feature New feature or request good first issue Good for newcomers labels Nov 15, 2022
@jiacai2050
Copy link
Contributor

There is no docs for sqlness, so this may not very friendly for volunteers...

@jiacai2050 jiacai2050 added help wanted Extra attention is needed A-test Area: Unit or integration test cases, or test framework labels Nov 16, 2022
@dust1
Copy link
Contributor

dust1 commented Nov 18, 2022

maybe I can do it. Can you assign it to me?

@jiacai2050
Copy link
Contributor

Yeah, go ahead.

There is a pending PR to update client, we will merge this soon, you can first figure out how to use sqlness framework since there are no docs for it.

@dust1
Copy link
Contributor

dust1 commented Nov 18, 2022

ok, I will create a new project to using sqlness.

@ShiKaiWi
Copy link
Member Author

ok, I will create a new project to using sqlness.

Actually, sqlness is almost same as the codes in the https://github.com/CeresDB/ceresdb/tree/main/tests/harness, maybe there is no need to create a new project?

@dust1
Copy link
Contributor

dust1 commented Nov 18, 2022

Actually, sqlness is almost same as the codes in the https://github.com/CeresDB/ceresdb/tree/main/tests/harness, maybe there is no need to create a new project?

yes, I mean i will try sqlness in another new project before this pr merge

@jiacai2050
Copy link
Contributor

@dust1 I have bump client to latest version in this PR #409, so there is nothing blocking this.

@waynexia
Copy link
Member

There is no docs for sqlness, so this may not very friendly for volunteers...

Currently, it only contains docs within the doc comment (///). Since this crate is not published yet, you need to run cargo doc --open to open it 🥲 Not very convenient but it should be better after our first publish.

@jiacai2050
Copy link
Contributor

jiacai2050 commented Dec 16, 2022

Got it, I will try to publish to crates.io when #473 is finished(ensure everything works as expected, and CeresDB can be used for demonstration).

@dust1
Copy link
Contributor

dust1 commented Dec 16, 2022

Do you need to add a new environment if you want to demonstrate? Currently only local

@jiacai2050
Copy link
Contributor

Multiple envs demo is required before publish, we can add it in sqlness repo.

We can create a demo project here, such as

$tree examples/
examples/
├── distributed
│   └── select.sql
└── local
    └── select.sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-test Area: Unit or integration test cases, or test framework feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants