fix: add page index for metadata #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelLeeHZ
changed the title
ShiKaiWi
reviewed
Jun 19, 2023
## Rationale In current design, sst files may be picked multiple times. ## Detailed Changes - Mark files as in compacting when pick files candidates, and reset it to false when CompactionTask is dropped. ## Test Plan Manually
jiacai2050
reviewed
Jun 19, 2023
## Rationale The metadata for arrow schema is encoded into the parquet file. However, this part is lost when building our custom metadata. ## Detailed Changes Keep the other metadata in the parquet metadata after extracting our custom metadata. ## Test Plan Add unit test `test_arrow_meta_data` for it.
## Rationale Part of apache#990. Some background jobs are still allowed to execute, and it will lead to data corrupted when a table is migrated between different nodes because of multiple writers for the same table. ## Detailed Changes Introduce a flag called `invalid` in the table data to denote whether the serial executor is valid, and this flag is protected with the `TableOpSerialExecutor` in table data, and the `TableOpSerialExecutor` won't be acquired if the flag is set, that is to say, any table operation including updating manifest, altering table and so on, can't be executed after the flag is set because these operations require the `TableOpSerialExecutor`. Finally, the flag will be set when the table is closed.
…eresdb into fix-page-index-for-metadata
Rachelint
added a commit
that referenced
this pull request
Jun 25, 2023
This reverts commit 41fe63a.
ShiKaiWi
added a commit
to ShiKaiWi/ceresdb
that referenced
this pull request
Jun 26, 2023
This reverts commit 41fe63a.
ShiKaiWi
pushed a commit
that referenced
this pull request
Jun 26, 2023
Rachelint
added a commit
that referenced
this pull request
Jun 28, 2023
This reverts commit 41fe63a.
dust1
pushed a commit
to dust1/ceresdb
that referenced
this pull request
Aug 9, 2023
## Rationale Now there is no page index in the `meta_data`, we should build page index if we want to use row selection. ## Detailed Changes * build page index for `meta_data` * add some debug log ## Test Plan --------- Co-authored-by: Jiacai Liu <dev@liujiacai.net> Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
dust1
pushed a commit
to dust1/ceresdb
that referenced
this pull request
Aug 9, 2023
This reverts commit 41fe63a. ## Rationale apache#1000 leads to some commits missing. ## Detailed Changes Revert apache#1000 ## Test Plan
dust1
pushed a commit
to dust1/ceresdb
that referenced
this pull request
Aug 9, 2023
## Rationale apache#1000 was reverted in apache#1026, here to create a new one. See details in apache#1000 ## Detailed Changes add page index for metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Now there is no page index in the
meta_data, we should build page index if we want to use row selection.Detailed Changes
meta_dataTest Plan