Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid crash due to empty sql #1024

Merged
merged 2 commits into from
Jun 25, 2023

Conversation

tanruixiang
Copy link
Member

@tanruixiang tanruixiang commented Jun 25, 2023

Rationale

close #1022

Detailed Changes

Check statements' len before parse table name

Test Plan

add ut.

Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit a563606 into apache:main Jun 25, 2023
6 checks passed
@tanruixiang tanruixiang deleted the fix_parse_empty_sql branch July 12, 2023 01:45
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
close apache#1022

## Detailed Changes
Check statements' len before parse table name

## Test Plan
add ut.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the sql is empty comment, ceresdb will crash
2 participants