Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add http write metrics #1045

Merged
merged 3 commits into from
Jul 6, 2023
Merged

refactor: add http write metrics #1045

merged 3 commits into from
Jul 6, 2023

Conversation

baojinri
Copy link
Contributor

@baojinri baojinri commented Jul 4, 2023

Rationale

Add http write failed counter metrics.

Detailed Changes

  • Add http counter metric in proxy.

Test Plan

Existing tests

jiacai2050
jiacai2050 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit f1bd883 into apache:main Jul 6, 2023
6 checks passed
@baojinri baojinri deleted the refactor-add-http-write-metrics branch July 7, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baojinri @jiacai2050