Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warning when query's timestamp is exceeding table's ttl #1054

Merged
merged 12 commits into from
Jul 11, 2023
Merged

feat: warning when query's timestamp is exceeding table's ttl #1054

merged 12 commits into from
Jul 11, 2023

Conversation

tanruixiang
Copy link
Member

@tanruixiang tanruixiang commented Jul 6, 2023 •
edited by jiacai2050

Rationale

Close #939

Detailed Changes

When query's time range exceed ttl, log warning message.

Test Plan

Manual test

2023-07-11 15:35:18.587 WARN [proxy/src/read.rs:168] Query time range maybe exceed TTL, sql:select * from demo2
where timestamp < 1

@tanruixiang tanruixiang marked this pull request as ready for review July 7, 2023 08:50
jiacai2050
jiacai2050 reviewed Jul 7, 2023
View reviewed changes
proxy/Cargo.toml Outdated Show resolved Hide resolved
proxy/src/error.rs Outdated Show resolved Hide resolved
proxy/src/lib.rs Outdated Show resolved Hide resolved
proxy/src/read.rs Outdated Show resolved Hide resolved
jiacai2050
jiacai2050 reviewed Jul 10, 2023
View reviewed changes
proxy/src/lib.rs Outdated Show resolved Hide resolved
jiacai2050
jiacai2050 reviewed Jul 11, 2023
View reviewed changes
common_types/src/lib.rs Show resolved Hide resolved
common_util/src/time.rs Outdated Show resolved Hide resolved
proxy/src/lib.rs Outdated Show resolved Hide resolved
server/src/http.rs Outdated Show resolved Hide resolved
jiacai2050
jiacai2050 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 794eb19 into apache:main Jul 11, 2023
6 checks passed
@tanruixiang tanruixiang deleted the ttl_warning branch July 12, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When querying data exceeding the ttl
2 participants
@tanruixiang @jiacai2050