fix: directly return when found no table datas to replay #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
directly-return-when-found-nothing-repaly
branch
from
abbdbd8
to
41aa06c
Compare
Rachelint
added a commit
to Rachelint/ceresdb
that referenced
this pull request
Jul 11, 2023
## Rationale Now it will still scan logs from wal when no table datas needed to replay, it should directly return actually. ## Detailed Changes Add a fast path to return directly when no table datas needed to replay. ## Test Plan Test manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Now it will still scan logs from wal when no table datas needed to replay, it should directly return actually.
Detailed Changes
Add a fast path to return directly when no table datas needed to replay.
Test Plan
Test manually.