Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quote column name in prom query filter #1083

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix: quote column name in prom query filter #1083

merged 2 commits into from
Jul 20, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Jul 19, 2023 •
edited

Rationale

PromQL query should be case-sensitive for column name

Detailed Changes

  • Use ident when construct filter.

Test Plan

Update integration tests and UT

ShiKaiWi
ShiKaiWi approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit aadfa0e into apache:main Jul 20, 2023
6 checks passed
@jiacai2050 jiacai2050 deleted the fix-prom-col branch July 20, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiacai2050 @ShiKaiWi