Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: separate some modules from common_types #1084

Merged
merged 5 commits into from
Jul 19, 2023
Merged

fix: separate some modules from common_types #1084

merged 5 commits into from
Jul 19, 2023

Conversation

ShiKaiWi
Copy link
Member

Rationale

Some modules should not be set on the common_types.

Detailed Changes

  • Move some modules from the common_types crate
  • Remove unnecessary features of common_types crate
  • Remove test feature and tests sub-module from test_util crate

Test Plan

Existing tests.

jiacai2050
jiacai2050 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ShiKaiWi ShiKaiWi merged commit ec47df5 into apache:main Jul 19, 2023
6 checks passed
@ShiKaiWi ShiKaiWi deleted the fix-deps branch July 19, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShiKaiWi @jiacai2050