fix: obkv wal open #1117
Merged
fix: obkv wal open #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Jul 28, 2023
Rachelint
force-pushed
the
fix-obkv-wal-open
branch
from
0ea9dc0
to
49fceb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
In some cases(such as
Manifest::do_snapshot),actual_next_sequencemaybe less thanstart_sequence, and it will check this then return error in OBKV WAl.In this pr, I refactor this open logic.
Detailed Changes
Refactor wal open logic to allow
actual_next_sequenceless thanstart_sequence.Test Plan
Test by exist tests.