refactor: use BinaryExpr to present regex filter
#1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanruixiang
changed the title
BinaryExpr to present regex sql
jiacai2050
reviewed
Aug 3, 2023
jiacai2050
changed the title
BinaryExpr to present regex sqlBinaryExpr to present regex sql
jiacai2050
changed the title
BinaryExpr to present regex sqlBinaryExpr to present regex condition
jiacai2050
changed the title
BinaryExpr to present regex conditionBinaryExpr to present regex filter
jiacai2050
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Now
promqlusesregexp_matchmacro to present the regex expr, which is not friendly for optimizing.Detailed Changes
Test Plan
ut