refactor: add request id in context #1153

jiacai2050 · 2023-08-15T10:08:18Z

Rationale

Currently when query failed, the error log doesn't contain request id, this makes it's very hard to tell how long the error query takes.

Add request_id in context, and print this ctx when query failed.
Remove enable_partition_table_access, runtime from context to avoid unnecessary clone.
Remove unnecessary param's move, change to reference.

proxy/src/grpc/sql_query.rs

proxy/src/lib.rs

proxy/src/context.rs

proxy/src/http/prom.rs

ShiKaiWi

LGTM

jiacai2050 requested review from ShiKaiWi and Rachelint August 15, 2023 10:12

refactor: add request id in context

492aa28

jiacai2050 force-pushed the fix-req-id branch from d533d98 to 492aa28 Compare August 15, 2023 10:25

jiacai2050 added 2 commits August 15, 2023 21:04

fix ci

e2bb704

refactor remaining request id

08f3f68

ShiKaiWi reviewed Aug 16, 2023

View reviewed changes

proxy/src/grpc/sql_query.rs Outdated Show resolved Hide resolved

proxy/src/lib.rs Show resolved Hide resolved

Rachelint reviewed Aug 16, 2023

View reviewed changes

proxy/src/context.rs Show resolved Hide resolved

Rachelint reviewed Aug 16, 2023

View reviewed changes

proxy/src/http/prom.rs Outdated Show resolved Hide resolved

proxy/src/http/prom.rs Outdated Show resolved Hide resolved

jiacai2050 added 2 commits August 16, 2023 15:51

typo

72d2648

remove unnecessary spawn

551b481

ShiKaiWi approved these changes Aug 16, 2023

View reviewed changes

ShiKaiWi merged commit 62b061c into apache:main Aug 16, 2023
6 checks passed

jiacai2050 deleted the fix-req-id branch August 16, 2023 11:08