chore: define QueryEngine and wrap all things into it
#1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
reviewed
Aug 18, 2023
Rachelint
force-pushed
the
refactor-query-engine-again
branch
from
df1a5ee
to
3d66799
Compare
Rachelint
force-pushed
the
refactor-query-engine-again
branch
from
77098fb
to
1f31640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When I add
PhysicalPlanEncoder, I found there have been too many sub-modules inquery_enginecrate now... And I foudn in fact we always use them together, so I decide to defineQueryEnginetrait to integrate them.Detailed Changes
PhysicalPlanEncoderand its datafusion impl.Executor.QueryEngineto integratePhysicalPlanner,PhysicalPlanEncoder,Executor.Test Plan
Test by exist tests.