fix: not consume all the datums if some of them is empty #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
fix-partition-rule-computing
branch
from
9510f4e
to
8c0d60f
Compare
jiacai2050
reviewed
Aug 29, 2023
ShiKaiWi
force-pushed
the
fix-partition-rule-computing
branch
2 times, most recently
from
31cb9b9
to
339a35d
Compare
jiacai2050
reviewed
Aug 30, 2023
ShiKaiWi
force-pushed
the
fix-partition-rule-computing
branch
from
339a35d
to
f55b7c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The remaining datums won't be consumed for computing partition if there is one empty datum in them.
Detailed Changes
Avoid break when encounter an empty string.
Test Plan
Add a unit test for this case.