feat: refactor Resolver in dist sql query
#1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rachelint Would you fill in the PR description? |
I want to refactor something again, I will fill in related information when this pr is ready for review. |
Rachelint
force-pushed
the
dist-sql-query-new-resolver
branch
2 times, most recently
from
1ed9f78
to
a4d1307
Compare
Rachelint
force-pushed
the
dist-sql-query-new-resolver
branch
from
a4d1307
to
95c13d8
Compare
ShiKaiWi
reviewed
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Part of #1112
The old resolver has some problems, need to refactor before adding it into the main query process.
Detailed Changes
Resolverin dist sql query.Test Plan
Test by richer unit tests.