Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add meta stable check into integration test #1202

Merged

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Sep 7, 2023

Rationale

Currently, we just left 20s for ceresmeta to do the initialization work in integration test.
However, it will be not enough something... And the test failure will make us so panic...
In this pr, I add a meta stable check to reduce the integration test failure.

Detailed Changes

Add a meta stable check by keep creating a radom named table utill succeeding(surely, retry max exists).

Test Plan

Test manually.

@Rachelint Rachelint marked this pull request as ready for review September 7, 2023 11:24
@Rachelint Rachelint force-pushed the add-meta-health-check-in-integration-test branch from b2777e0 to 3b9437f Compare September 7, 2023 12:44
@Rachelint Rachelint force-pushed the add-meta-health-check-in-integration-test branch from 3b9437f to 9429aeb Compare September 7, 2023 12:45
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 0451a9c into apache:main Sep 8, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants