refactor: avoid memory allocation during partition write requests #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
refactor-partition-by
branch
from
513c02e
to
c2e0d49
Compare
Rachelint
reviewed
Sep 14, 2023
jiacai2050
reviewed
Sep 18, 2023
jiacai2050
reviewed
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some memory allocation during partitioning write request can be avoided.
Detailed Changes
Introduce an enum called
PartitionedRowsas the return type ofPartitionRule.locate_partitions_for_writeto avoid unnecessary memory allocation.Test Plan
Existing test.