Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip update shard status when create/remove table #1210

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Sep 12, 2023

Rationale

In one of our deployments, I have one shard change its status from Ready to Init, there is no open/close shards requests between this change, so I add some info log to help investigate this issue.

Detailed Changes

  • Skip update shard status when create/remove table

Test Plan

TBD

@jiacai2050 jiacai2050 changed the title chore: add info logs when shard is added or remove from shard_set fix: skip update shard status when create/remove table Sep 12, 2023
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 3b9beb1 into apache:main Sep 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants