Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade rust-rocksdb #1223

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

tisonkun
Copy link
Member

Rationale

This closes #1222.

Fix compilation on macOS M1.

Detailed Changes

Upgrade TiKV's RocksDB crate to a new commit.

Test Plan

Existing CI workflows.

Signed-off-by: tison <wander4096@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Sep 19, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050
Copy link
Contributor

Do this update fix your issue?

I also have this issue in my macbook, the solution I use is comment L774:

    if !ident_ok(string) {
        //panic!("{:?} is not a valid Ident", string);
    }

It seems the generated variable is not used at all.

@tisonkun
Copy link
Member Author

Do this update fix your issue?

Yes.

@jiacai2050 jiacai2050 merged commit 20ee56e into apache:main Sep 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build librocksdb-sys on macOS with Apple M1 chip
4 participants