refactor: first step to move all packages under src folder #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
|
Perhaps we still need changes some other relative paths, I'd like to let CI helps me :D |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Rachelint
reviewed
Sep 24, 2023
tanruixiang
added a commit
that referenced
this pull request
Sep 26, 2023
## Rationale After #1226 changing directories , `build.rs` will not be used to set environment variables, `ceresdb-server --verion` will return None. ## Detailed Changes move `build.rs` into`src/ceresdb/` ## Test Plan Add a test case to ensure all environment variables are got.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The final result will be moved all packaged under the
srcfolder so that we have a consistent and concise layout.Take materialize as an example: https://github.com/MaterializeInc/materialize/tree/main/src
Detailed Changes
First step: move
srctosrc/serverwhile keep all the effective code and config the same. So that we get rid of the special case first.Test Plan
Everything should keep AS IS and existing tests should pass.