Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rewrite not in expr to in #1236

Merged
merged 9 commits into from
Oct 8, 2023
Merged

feat: rewrite not in expr to in #1236

merged 9 commits into from
Oct 8, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Oct 1, 2023 •
edited

Rationale

Current filter is based on bloom-filter like structure, it can give accurate answer if an item doesn't exist in one collection, so by convert col != value to col == value2, we can fully utilize this feature.

Detailed Changes

  • Save column value to SST metadata when distinct value is less than 20.
  • Rewrite not-like expr to its opposite.

Test Plan

New UT.

@tanruixiang tanruixiang changed the title feat: rewrite not in expr to in feat: rewrite not in expr to in Oct 2, 2023
@jiacai2050 jiacai2050 marked this pull request as ready for review October 2, 2023 09:56
chunshao90
chunshao90 reviewed Oct 8, 2023
View reviewed changes
table_engine/src/predicate.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/row_group_pruner.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/writer.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/row_group_pruner.rs Show resolved Hide resolved
chunshao90
chunshao90 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 8e8304f into apache:main Oct 8, 2023
7 checks passed
@jiacai2050 jiacai2050 deleted the feat-optimize-not-in branch October 8, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunshao90 chunshao90 chunshao90 approved these changes

@ShiKaiWi ShiKaiWi Awaiting requested review from ShiKaiWi

@Rachelint Rachelint Awaiting requested review from Rachelint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiacai2050 @chunshao90