feat: convert table name to lowercase when not quoted #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
changed the title
jiacai2050
force-pushed
the
feat-normalize-identifier
branch
from
c53401a
to
dd7e455
Compare
Rachelint
pushed a commit
to Rachelint/ceresdb
that referenced
this pull request
Dec 2, 2022
* normalize table name * add testcase
Rachelint
added a commit
to Rachelint/ceresdb
that referenced
this pull request
Dec 7, 2022
Rachelint
added a commit
to Rachelint/ceresdb
that referenced
this pull request
Dec 7, 2022
Rachelint
added a commit
to Rachelint/ceresdb
that referenced
this pull request
Dec 7, 2022
ShiKaiWi
pushed a commit
that referenced
this pull request
Dec 7, 2022
* convert table name to quoted style in sql statement. * add unit test. * revert pr444(#444). * refactor related integration tests. * remove useless commets. * refactor the way of extracting table name.
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* normalize table name * add testcase
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* convert table name to quoted style in sql statement. * add unit test. * revert pr444(apache#444). * refactor related integration tests. * remove useless commets. * refactor the way of extracting table name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #442
Rationale for this change
What changes are included in this PR?
Change table name to lowercase when not quoted
Are there any user-facing changes?
Yes, table name will be converted to lowercase when not quoted
How does this change test
Test harness