Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic setting log level #445

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

ZuLiangWang
Copy link
Contributor

@ZuLiangWang ZuLiangWang commented Dec 2, 2022

Which issue does this PR close?

Closes #436

Rationale for this change

Support dynamic setting of log level to avoid server restart.

What changes are included in this PR?

Add API logLevel, log level could be updated like this:

curl --location --request PUT 'http://localhost:5440/log_level/debug'

Are there any user-facing changes?

None.

How does this change test

Manual test in local environment.

@ZuLiangWang ZuLiangWang force-pushed the update_log_level branch 3 times, most recently from 47ef6c2 to 3acee14 Compare December 2, 2022 07:04
server/src/http.rs Outdated Show resolved Hide resolved
server/src/http.rs Outdated Show resolved Hide resolved
server/src/http.rs Outdated Show resolved Hide resolved
server/src/http.rs Outdated Show resolved Hide resolved
@ZuLiangWang ZuLiangWang force-pushed the update_log_level branch 6 times, most recently from 402d107 to 7cf06b1 Compare December 5, 2022 07:05
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 7c93a75 into apache:main Dec 5, 2022
Rachelint pushed a commit to Rachelint/ceresdb that referenced this pull request Dec 6, 2022
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dynamic setting of log level to avoid server restart
2 participants