Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disk cache value crc #447

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

jiacai2050
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Followup PR of #420, add CRC for cached bytes

What changes are included in this PR?

Are there any user-facing changes?

No

How does this change test

UT

@jiacai2050 jiacai2050 changed the title add disk cache value crc feat: add disk cache value crc Dec 5, 2022
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jiacai2050 jiacai2050 merged commit d61a79c into apache:main Dec 5, 2022
@jiacai2050 jiacai2050 deleted the feat-disk-cache-crc branch December 5, 2022 10:41
Rachelint pushed a commit to Rachelint/ceresdb that referenced this pull request Dec 6, 2022
* add disk cache value crc

* add ut
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* add disk cache value crc

* add ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants