feat: make rocksdb wal compatible with other distributed implementation #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
merge-distributed-compatible-rocksdb-wal-to-main
branch
from
92c8324
to
33b4be7
Compare
ShiKaiWi
reviewed
Dec 7, 2022
Rachelint
force-pushed
the
merge-distributed-compatible-rocksdb-wal-to-main
branch
from
a9161bb
to
318e92c
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…on (apache#460) * modify wal on rocksdb to be compatible with other distributed implementations. * address CR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Now, If you write log with a not default region id in key, you will be unable to recover it when you restart the database(use a rocksdb based wal). It make no sense, so we should adjust the recover process in rocksdb based wal.
What changes are included in this PR?
Adjust the recover process in rocksdb based wal.
Are there any user-facing changes?
None.
How does this change test
Test by ut.