Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support prefix for object store #463

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Dec 7, 2022

Which issue does this PR close?

Closes #

Rationale for this change

Currently, there is no namespace concept for the object store, that is to say, one bucket can be only used for one ceresdb cluster, which is not convenient for deploying multiple ceresdb clusters.

What changes are included in this PR?

  • Support object store with prefix configuraiton;
  • Remove cached store which is useless now;
  • Adjust the default configurations for mem cache (larger partition bits) and disk cache(disabled by default);

Are there any user-facing changes?

None.

How does this change test

New UT.

Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 505b9ac into apache:main Dec 8, 2022
@ShiKaiWi ShiKaiWi deleted the feat-object-store-prefix branch December 8, 2022 02:04
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: support prefix for object store

* chore: remove CacheStore

* config: adjust the default settings for mem cache and disk cache

* chore: make clippy happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants