feat: make initializing of buffered streams in MergeIterator concurrent
#466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
parallel-initializing-in-merge-iterator
branch
from
450d3cc
to
047a2ce
Compare
Rachelint
changed the title
MergeIterator concurrentMergeIterator concurrent
Rachelint
force-pushed
the
parallel-initializing-in-merge-iterator
branch
from
047a2ce
to
52e9a1b
Compare
3 tasks
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
We will build some
BufferedStreams inMergeIterator::init_if_necessarysequentially and while buildingBufferedStream, it needs to pull a batch to fill the buffer.Obviously, the initial pullings above can be concurrent.
What changes are included in this PR?
Make initializing of buffered stream in
MergeIteratorconcurrent.Are there any user-facing changes?
None.
How does this change test
Test by ut.