feat: add max_input_sstable_size #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
changed the title
ShiKaiWi
reviewed
Dec 15, 2022
jiacai2050
force-pushed
the
fix-max-compact-size
branch
from
65ffacc
to
07ed77e
Compare
jiacai2050
force-pushed
the
fix-max-compact-size
branch
from
1d0fcd5
to
e5f8f66
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* add max_input_sstable_size * add unit test * fix unit test * remove max input size from table options * read from env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #408
Rationale for this change
The target of #408 plan to limit output sst file, but there is no easy way to tell how large the output file will be, so
this PR use another strategy: limit total input size.
What changes are included in this PR?
When pick files for compaction, add a new limit:
max_input_sstable_size,it will control total input file size to compact.
For now, we can custom it via environment variables, such as
Are there any user-facing changes?
No
How does this change test
New unit test
test_size_tiered_picker