-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support parsing partition table creating #487
Merged
Rachelint
merged 2 commits into
apache:main
from
Rachelint:parse-creating-partition-table
Dec 20, 2022
Merged
feat: support parsing partition table creating #487
Rachelint
merged 2 commits into
apache:main
from
Rachelint:parse-creating-partition-table
Dec 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunshao90
reviewed
Dec 19, 2022
chunshao90
reviewed
Dec 19, 2022
ZuLiangWang
requested changes
Dec 19, 2022
Rachelint
force-pushed
the
parse-creating-partition-table
branch
from
December 19, 2022 16:11
2a54815
to
96af5ec
Compare
ZuLiangWang
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rachelint
force-pushed
the
parse-creating-partition-table
branch
3 times, most recently
from
December 20, 2022 06:41
526b488
to
fbd5e19
Compare
chunshao90
reviewed
Dec 20, 2022
Rachelint
force-pushed
the
parse-creating-partition-table
branch
3 times, most recently
from
December 20, 2022 08:08
c7ed450
to
b1bbd51
Compare
chunshao90
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rachelint
force-pushed
the
parse-creating-partition-table
branch
from
December 20, 2022 09:30
b1bbd51
to
2e1e7e1
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* supprot parsing partition table creating. * address CR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
We need to support table partition now, this pr is for supporting parsing the related sql to statement.
The syntax is same as Mysql .
But now, we only support the hash strategy.
What changes are included in this PR?
Add sql syntax support for creating partition table(only hash strategy).
Mainly modify
sql/src/parser.rs
.Are there any user-facing changes?
Ceresdb can accept related sql syntax now(but related function is not supported yet).
How does this change test
Test by ut.