Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support parsing partition table creating #487

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

Rachelint
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

We need to support table partition now, this pr is for supporting parsing the related sql to statement.
The syntax is same as Mysql .
But now, we only support the hash strategy.

What changes are included in this PR?

Add sql syntax support for creating partition table(only hash strategy).
Mainly modify sql/src/parser.rs.

Are there any user-facing changes?

Ceresdb can accept related sql syntax now(but related function is not supported yet).

How does this change test

Test by ut.

sql/src/parser.rs Outdated Show resolved Hide resolved
sql/src/parser.rs Outdated Show resolved Hide resolved
sql/src/ast.rs Show resolved Hide resolved
@Rachelint Rachelint force-pushed the parse-creating-partition-table branch from 2a54815 to 96af5ec Compare December 19, 2022 16:11
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint force-pushed the parse-creating-partition-table branch 3 times, most recently from 526b488 to fbd5e19 Compare December 20, 2022 06:41
sql/src/parser.rs Outdated Show resolved Hide resolved
sql/src/partition.rs Outdated Show resolved Hide resolved
@Rachelint Rachelint force-pushed the parse-creating-partition-table branch 3 times, most recently from c7ed450 to b1bbd51 Compare December 20, 2022 08:08
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint force-pushed the parse-creating-partition-table branch from b1bbd51 to 2e1e7e1 Compare December 20, 2022 09:30
@Rachelint Rachelint merged commit de9a81e into apache:main Dec 20, 2022
@chunshao90 chunshao90 mentioned this pull request Dec 20, 2022
7 tasks
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* supprot parsing partition table creating.

* address CR.
@Rachelint Rachelint deleted the parse-creating-partition-table branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants