feat: support ignore bloomfilter when compaction #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
changed the title
ShiKaiWi
force-pushed
the
feat-support-ignore-bloomfilter-when-compaction
branch
from
74738eb
to
e0d6e98
Compare
jiacai2050
reviewed
Dec 19, 2022
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* feat: support async reader option `just_once` * chore: remove sync parquet reader * chore: refactor the signature of `read_sst_meta` method * replace just_once with ReadFrequency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part #489
Rationale for this change
After #488, bloom filter has been optional, but the compaction procedure has no way to tell the SST reader to skip loading bloom filter. This PR will implement it.
What changes are included in this PR?
just_oncefield to SST reader to decide whether to skip updating cache;just_onceis set and predicates are not provided;Are there any user-facing changes?
None.
How does this change test
Existing tests.