Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove EncodingWriter #493

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

jiacai2050
Copy link
Contributor

Which issue does this PR close?

Closes #53.

We don't have plan to switch to parquet2 any more.

Rationale for this change

In old version of parquet, there is no way to get inner writer.

Upstream have added this method, so don't required this workaround.

What changes are included in this PR?

Are there any user-facing changes?

No

How does this change test

Old unit test

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit dbd45d3 into apache:main Dec 20, 2022
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

try to replace parquet with parquet2?
2 participants