Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support query limit by rule #494

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Closes #470

Rationale for this change

Refer to #470.

What changes are included in this PR?

  • Support limit query by BlockRule;
  • Add a BlockRule called QueryWithoutPredicate to block the query like select * from t;
  • Expose the operation of the block rules to http api service;

Are there any user-facing changes?

Support block query with block rules, especially, QueryWithoutPredicate.

How does this change test

New unit tests.

server/src/handlers/admin.rs Outdated Show resolved Hide resolved
server/src/handlers/admin.rs Outdated Show resolved Hide resolved
server/src/grpc/storage_service/write.rs Show resolved Hide resolved
server/src/limiter.rs Show resolved Hide resolved
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 0b05065 into apache:main Dec 21, 2022
@ShiKaiWi ShiKaiWi deleted the feat-query-limit branch December 21, 2022 03:03
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: support limit by rule

* Add new unit tests

* rename RejectRequest/Response to BlockRequest/Response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restriction on bad SQL for server stability
2 participants