Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust usage of sst type #499

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Prepare for #495

Rationale for this change

Refer to #495:

Currently, the sst type is used to decide which type of sst reader/builder to create, but this option is configured for table level, that is to say, one table can only use one sst type. I guess this is not reasonable, and it is more flexible and elegant to allow the data of one table being encoded in different sst formats. So I guess we make this option only works when deciding the type of sst builder, and add a new sst type called Auto for the flexibility of choosing a better sst format.

What changes are included in this PR?

  • Remove sst type option when reading sst;
  • Add a new sst type called Auto;

Are there any user-facing changes?

None.

How does this change test

Existing tests.

Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 1e2382a into apache:main Dec 21, 2022
@ShiKaiWi ShiKaiWi deleted the refactor-sst-type branch December 21, 2022 08:15
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants