refactor: separate object store from parquet sst async reader #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
refactor-sst-async-reader
branch
from
82ef3a9
to
c107f81
Compare
chunshao90
reviewed
Dec 22, 2022
ShiKaiWi
added a commit
that referenced
this pull request
Dec 27, 2022
* refactor: separate object store from parquet sst async reader (#503) * refactor: separate object store from parquet sst async reader * fix errors in unit tests * use const FOOTER_LEN * add GenericResult * refactor: recovery in standalone mode (#414) * refactor recovery in standalone mode. * make getting table infos dynamically. * define `LocalTablesRecoverer`. * address CR. * feat: support parse key partition (#506) * add key partition parser * refactor the codes * add unit test * fix show create table for partition table * address CR issues * supplement the error msg when fail to parse partition key * fix unit tests Co-authored-by: CooooolFrog <zuliangwanghust@gmail.com> * chore: define remote_engine grpc service (#505) Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com> * feat: impl key partition rule (#507) * impl key partition rule(draft). * refactor to more extensible and testable version. * add tests for key partition. * add df adapter and partition rule's building. * address CR. Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com> Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com> Co-authored-by: CooooolFrog <zuliangwanghust@gmail.com> Co-authored-by: chunshao.rcs <chunshao.rcs@antgroup.com>
ShiKaiWi
added a commit
to ShiKaiWi/ceresdb
that referenced
this pull request
Jan 4, 2023
…apache#503)" This reverts commit 436d4f0.
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…#503) * refactor: separate object store from parquet sst async reader * fix errors in unit tests * use const FOOTER_LEN * add GenericResult
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
apache#536) * Revert "refactor: separate object store from parquet sst async reader (apache#503)" This reverts commit be6002c. * fix missing package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Prepare for #495
Rationale for this change
In order to control how to decode our custom sst file, the object store must be separated from the Parquet SST async reader because the api of object store has no flexibility to introduce another footer after the original file content.
What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
Existing tests.