feat: support querying partition tables through select in #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
reviewed
Jan 16, 2023
ZuLiangWang
force-pushed
the
partition_read_in
branch
2 times, most recently
from
a4bfbb2
to
07e543f
Compare
Rachelint
reviewed
Jan 16, 2023
ZuLiangWang
force-pushed
the
partition_read_in
branch
2 times, most recently
from
b628035
to
178d0fe
Compare
ZuLiangWang
force-pushed
the
partition_read_in
branch
from
178d0fe
to
a4b0dfd
Compare
|
LGTM |
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
We implemented table partition in the last release, but querying partitioned tables through
select inwill lead to the failure to identify the correct partitions, resulting in full table scanning. We need to support select in to improve query performance.What changes are included in this PR?
select ininfilterExtractorAre there any user-facing changes?
None.
How does this change test
Pass unit test.