Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support drop partition table #532

Merged
merged 4 commits into from
Jan 6, 2023
Merged

feat: support drop partition table #532

merged 4 commits into from
Jan 6, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Jan 3, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Support drop partition table.

What changes are included in this PR?

Add PartitionInfo in DropTablePlan to support drop partition table.

Are there any user-facing changes?

Support drop partition table.

How does this change test

Manual testing with ceresmeta.

@chunshao90 chunshao90 marked this pull request as ready for review January 4, 2023 07:48
sql/src/planner.rs Outdated Show resolved Hide resolved
interpreters/src/table_manipulator/meta_based.rs Outdated Show resolved Hide resolved
sql/src/planner.rs Outdated Show resolved Hide resolved
interpreters/src/table_manipulator/meta_based.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sql/src/planner.rs Outdated Show resolved Hide resolved
sql/src/planner.rs Outdated Show resolved Hide resolved
@chunshao90 chunshao90 merged commit 8f2d2a3 into apache:main Jan 6, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: support drop partition table

* refactor code

* refactor by CR

* refactor by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants