Revert "refactor: separate object store from parquet sst async reader… #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apache#503)" This reverts commit 436d4f0.
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
apache#536) * Revert "refactor: separate object store from parquet sst async reader (apache#503)" This reverts commit be6002c. * fix missing package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 436d4f0. (#503)
Which issue does this PR close?
Closes #
Rationale for this change
After discussion, We find that there is no need to define a custom file format to wrap the real sst file encoded in different kinds of storage format. The real storage format will be told by the manifest module.
What changes are included in this PR?
Revert #503
Are there any user-facing changes?
None
How does this change test
No need.