Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add version in PartitionInfo #537

Merged
merged 2 commits into from
Jan 5, 2023
Merged

chore: add version in PartitionInfo #537

merged 2 commits into from
Jan 5, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Jan 4, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Add version field in PartitionInfo for future extension.

What changes are included in this PR?

  • Add version field in PartitionInfo for future extension.
  • Rename Definition to PartitionDefinition.

Are there any user-facing changes?

No.

How does this change test

Old tests have covered.

@chunshao90 chunshao90 marked this pull request as ready for review January 4, 2023 08:26
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 438d3d7 into apache:main Jan 5, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* chore: add version in PartitionInfo

* refactor by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants