support schema header for http/grpc service #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Jan 10, 2023
ShiKaiWi
force-pushed
the
feat-schema-header
branch
from
4cc33ad
to
af9e056
Compare
jiacai2050
reviewed
Jan 11, 2023
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* support schema header for http/grpc service * rename header value of the schema * add flag to control whether to enable use tenant as schema * remove commented clone impl for StorageServiceImpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Currently, it is unreasonable to use tenant as the schema when accessing grpc/http service.
What changes are included in this PR?
x-ceresdb-schema;tenantis still used as schema ifschemais not set.Are there any user-facing changes?
User now can use
x-ceresdb-schemaheader to set schema instead ofx-ceresdb-access-tenant.How does this change test
Existing tests.