feat: use arrow-ipc to communicate between remote server and client #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
changed the title
jiacai2050
force-pushed
the
feat-arrow-ipc
branch
from
645ff59
to
cd7408b
Compare
|
|
jiacai2050
force-pushed
the
feat-arrow-ipc
branch
2 times, most recently
from
a7c4794
to
863be12
Compare
jiacai2050
force-pushed
the
feat-arrow-ipc
branch
from
863be12
to
c497766
Compare
|
@Rachelint Thanks for remind. I have add a |
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…pache#552) * feat: use arrow-ipc to communicate bewteen remote server and client * add benchmarks * add zstd for ipc * add RemoteEngineVersion * fix message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
In current implementation, remote service communication bewteen ceresdb using
avro to serialize RecordBatch. For arrow ecosystem, there is a designated serialization method -- Arrow IPC
Some benchmark:
Encoded bytes using Arrow IPC will take more space 1348496/904634 = 1.4, but it's more much less time.
After zstd compression, IPC is better than avro in both size and speed.
What changes are included in this PR?
Replace avro with arrow ipc for remote service communication
Are there any user-facing changes?
No
How does this change test
New UT
test_ipc_encode_decode